Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Governance Module (Bianjie) #1041

Closed
wants to merge 14 commits into from

Conversation

haifengxi
Copy link

@haifengxi haifengxi commented May 23, 2018

This PR tracks x/gov implementation by the Bianjie team, contributing to existing PR: #535

@haifengxi haifengxi requested a review from ebuchman as a code owner May 23, 2018 07:56
@haifengxi haifengxi changed the title WIP: Governance Module (Bianjie Contribution) WIP: Governance Module (Bianjie) May 24, 2018
@sunnya97
Copy link
Member

sunnya97 commented Jun 1, 2018

Awesome, thanks for the contribution. In this PR, there seems to be a lot of stuff happening at once, but largely in two different categories:

  1. Catching this branch up with the latest features of the rest of the SDK (ie Tags, Codespacer, cli stuff, etc)
  2. Adding to the logic of the governance module/keeper.

Regarding category 2, we are making some updates to the MVP spec right now (such as #1060 and #1104). For this reason, could you please create a separate PR focusing on stuff in category 1, and then we can coordinate around category 2 changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants